Adopt the Whitaker Dylint suite in the lint gate and CI - #21
Conversation
Align Statelet's existing template-provided Whitaker wiring with the estate-standard adoption pattern used in leynos/netsuke#410: - Pin the Whitaker suite to the released installer version 0.2.5 via `cargo binstall whitaker-installer@0.2.5` instead of building the installer from a git revision, cutting CI install time and matching the rest of the estate. - Cache only the installer binary and the binstall cache, keyed on the runner OS, architecture, and installer version, so cache entries invalidate when the pinned version changes. - Simplify the Makefile to the standard `WHITAKER ?= whitaker` variable and drop the bespoke PATH-resolution logic; the wrapper is installed on PATH both locally and on CI runners. - Update the `lint` target help text to mention the Whitaker suite. The suite reports no findings on this crate, so no code changes or dylint.toml exclusions were required. The Dependabot-actor skip on the dependency audit step is left untouched.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 7 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 559ebc06dd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This project builds with the Cranelift debug backend, so the Dylint driver's pinned nightly needs `rustc-codegen-cranelift` installed. Restore the installer's `--cranelift` flag, which the standardized install step had dropped.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Pass WHITAKER_INSTALLER_VERSION to the run block through the shell
environment rather than inline `${{ env }}` template expansion, which
zizmor flags as a template-injection risk; the job-level `env:` block
already exports the variable. Add `--locked` to the cargo binstall
invocation so that its compile-from-source fallback resolves
dependencies from the published lockfile, keeping fallback builds
reproducible.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
1 participant
Summary
This pull request aligns Statelet with the estate-wide rollout of the
Whitaker Dylint suite (reference adoption: leynos/netsuke#410). Statelet's
crate template already wired Whitaker into
make lintand CI, but it builtthe installer from a pinned git revision and carried bespoke PATH-resolution
logic in the Makefile. The change pins the suite to the released installer
version 0.2.5, installed via
cargo binstall, and simplifies the Makefile tothe standard
WHITAKER ?= whitakerconvention. The CI cache now covers onlythe installer binary and the binstall cache, keyed on the runner OS,
architecture, and installer version, so entries invalidate when the pin
changes. The Dependabot-actor skip on the dependency audit step is
deliberately left untouched.
The suite reports no findings on this crate, so no code changes or
dylint.tomlexclusions were required.Review walkthrough
Makefile:replaces the
$(or ...)wrapper-resolution and PATH injection withWHITAKER ?= whitaker, and updates thelinttarget's help text tomention the Whitaker suite.
.github/workflows/ci.yml:replaces
WHITAKER_INSTALLER_REVwithWHITAKER_INSTALLER_VERSION: '0.2.5',narrows the cache step to
~/.cargo/bin/whitaker-installerand~/.cache/cargo-binstall, and installs the released installer viacargo binstall --no-confirm whitaker-installer@0.2.5before runningwhitaker-installer.Validation
env -u WHITAKER RUSTFLAGS="-D warnings" whitaker --all -- --all-targets --all-features— exit 0, no findings.make check-fmt— passed.make lint(rustdoc, Clippy, and Whitaker via the Makefile default) — passed.make typecheck— passed.make test(nextest and doctests) — passed, 1 test and 1 doctest.make markdownlint— 20 files, 0 errors.make nixie— all Mermaid diagrams validated.mbake validate Makefile— valid syntax.